ZIP 32: Add an Account discovery section #621
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daira
force-pushed
the
zip-0032-account-discovery
branch
2 times, most recently
from
36bd59c to
21d49b8
Compare
Signed-off-by: Daira Hopwood <[email protected]>
daira
force-pushed
the
zip-0032-account-discovery
branch
from
21d49b8 to
8d0b7ed
Compare
dconnolly
reviewed
Jun 15, 2022
Comment on lines
+555
to
+556
| A wallet that imports a master seed from an external source SHOULD attempt to discover accounts in the | ||
| following manner. |
There was a problem hiding this comment.
'account' is used and one can infer its meaning from context but it would be nice to have an explicit definition near the top of this document
dconnolly
reviewed
Jun 15, 2022
| * For :math:`m \in M`: | ||
|
|
||
| 1. Derive the external full viewing key of the account at path :math:`m / purpose' / coin\_type' / account'`. | ||
| 2. Scan for transactions sending to this account using the algorithm in [#protocol-scan]_. |
There was a problem hiding this comment.
Also scan for tx's sending from this account?
dconnolly
reviewed
Jun 15, 2022
| * If the wallet supports Sapling addresses, then for each address index starting from :math:`address\_index = 0`: | ||
|
|
||
| 1. Derive the external full viewing key of the Sapling address at path :math:`m_{Sapling} / purpose' / coin\_type' / \mathtt{0x7FFFFFFF}' / address\_index`. | ||
| 2. Scan for transactions sending to this address using the algorithm in [#protocol-scan]_. |
There was a problem hiding this comment.
Also scan for tx's sending from this account?
dconnolly
reviewed
Jun 15, 2022
| the legacy Sapling address chain. We scan just the external chains, because internal chains receive only | ||
| coins that come from the associated external chains. | ||
|
|
||
| Wallet software should warn when the user is trying to exceed the gap limit on an external chain by |
There was a problem hiding this comment.
Suggested change
| Wallet software should warn when the user is trying to exceed the gap limit on an external chain by | |
| Wallet software SHOULD warn when the user is trying to exceed the gap limit on an external chain by |
dconnolly
reviewed
Jun 15, 2022
| coins that come from the associated external chains. | ||
|
|
||
| Wallet software should warn when the user is trying to exceed the gap limit on an external chain by | ||
| generating a new address. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.