Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transparent address gap limit handling & general address rotation functionality. #1673

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

zcash_client_sqlite: Add a test for external transparent address gap …

6238af4
Select commit
Loading
Failed to load commit list.
Open

Add transparent address gap limit handling & general address rotation functionality. #1673

zcash_client_sqlite: Add a test for external transparent address gap …
6238af4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 31, 2024 in 1s

52.08% (-0.15%) compared to 5651d80, passed because coverage increased by 0.29% when compared to adjusted base (51.79%)

View this Pull Request on Codecov

52.08% (-0.15%) compared to 5651d80, passed because coverage increased by 0.29% when compared to adjusted base (51.79%)

Details

Codecov Report

Attention: Patch coverage is 59.70549% with 301 lines in your changes missing coverage. Please review.

Project coverage is 52.08%. Comparing base (5651d80) to head (6238af4).

Files with missing lines Patch % Lines
.../init/migrations/transparent_gap_limit_handling.rs 46.37% 74 Missing ⚠️
zcash_client_sqlite/src/wallet.rs 60.99% 55 Missing ⚠️
zcash_client_sqlite/src/lib.rs 52.33% 51 Missing ⚠️
zcash_client_sqlite/src/wallet/transparent.rs 73.97% 51 Missing ⚠️
zcash_client_sqlite/src/wallet/orchard.rs 0.00% 27 Missing ⚠️
.../src/wallet/init/migrations/ephemeral_addresses.rs 56.00% 11 Missing ⚠️
zcash_client_sqlite/src/wallet/sapling.rs 68.96% 9 Missing ⚠️
..._client_sqlite/src/wallet/transparent/ephemeral.rs 59.09% 9 Missing ⚠️
zcash_client_backend/src/data_api.rs 0.00% 3 Missing ⚠️
zcash_client_sqlite/src/error.rs 0.00% 3 Missing ⚠️
... and 4 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1673      +/-   ##
==========================================
- Coverage   52.22%   52.08%   -0.15%     
==========================================
  Files         179      180       +1     
  Lines       21353    21759     +406     
==========================================
+ Hits        11152    11333     +181     
- Misses      10201    10426     +225

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov