-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for transparent-source-only (TEX) addresses #1257
Conversation
4f54370
to
24b8147
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1257 +/- ##
==========================================
+ Coverage 63.20% 64.19% +0.99%
==========================================
Files 128 130 +2
Lines 14869 15423 +554
==========================================
+ Hits 9398 9901 +503
- Misses 5471 5522 +51 ☔ View full report in Codecov by Sentry. |
0fc932c
to
62298aa
Compare
a8e279e
to
1af90e3
Compare
85dd964
to
7c8e775
Compare
ba99ab5
to
964ef81
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK with a few minor notes.
if d_tx | ||
.tx() | ||
.transparent_bundle() | ||
.iter() | ||
.any(|b| !b.vout.is_empty()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a nit, this condition did allow us to skip the get_funding_accounts
query; it's a trivial optimization, but it avoided a database roundtrip by just inspecting in-memory data.
e097829
to
ba32fba
Compare
f01a878
to
5bfd5e6
Compare
Co-authored-by: Jack Grigg <[email protected]>
5bfd5e6
to
24b6d50
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK ab7f1b9
This also provides additional documentation for why it's necessary to store ephemeral_addresses table entries at indicies that do not correspond to valid addresses.
ab7f1b9
to
f8bedd8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK f8bedd8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK f8bedd8
pub(super) const INDEX_EPHEMERAL_ADDRESSES_ADDRESS: &str = r#" | ||
CREATE INDEX ephemeral_addresses_address ON ephemeral_addresses ( | ||
address ASC | ||
)"#; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reference, the ephemeral_addr_uniq
constraint has essentially the same effect as a unique index.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Post-hoc utACK for the last 4 commits, i.e. up to and including f8bedd8.
fixes #1167