fix: allow empty input tables #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uniqueg
requested changes
Feb 23, 2024
…thub.com:zavolanlab/mirflowz into 136-fix-merge_tablesr-fails-if-given-empty-input
uniqueg
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
It's actually really nice with the linting and docstrings and all of that good stuff. Good job! 👍
It just would have been nice to keep the linting and other improvements separate from the fix that this PR was supposed to be about, especially as they now make up, like, 95% of the whole PR. I really don't even know how to name this PR properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #136 .
The changes in
merge_tables.Rare:get_table()that tries to read the input file and if empty, create a data frame made of one row withNAs in each columnmerge_tables()function to include the new function and, if an empty file was present, remove the row with aNAin the miRNA species column