-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: describe workflow rationale #135
Conversation
Merge with dev branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of issues, but shouldn't take long to fix. Didn't look at all of the many changes in the pipeline documentation file carefully - but it looks mostly fine :)
To be fair, it's probably one of the 10 most detailed pipeline documentations ever written 🤣
Oh, and please check why the static code analysis fails. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the open comments and send for re-review when you are done 🙏
…olanlab/mirflowz into 126-docs-describe-workflow-rationale
@deliaBlue: Somehow this PR showed up in my GitHub notifications, probably because you added commits? Is there anything I should do at this point? Or am I still waiting until you resolve the open conversations and tell me to review? :) |
Righr now this PR lacks the documentation of the recently-merged PRs. Also, the unsolved comments are halfway through. We discussed them a while ago but leave the PR for when the other PRs were merged due to the different style in the documentation. As soon as it is done, I will ask you to review it :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! :)
This PR closes #126.
The changes applied are:
pipeline_documentation.md