-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: set intermediate and final output files #129
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work :) Couple of comments, but shouldn't be all that much
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll approve this now. You can see how/whether you address (or not) the two open conversations and then merge.
Fixes #86
config_template.yaml
andconfig_schema.json
onfailure
andonsuccess
handlers in the main Snakefile so intermediate files are not lost if the workflow fails and removed otherwise.README.md
with a brief explanation of the files that are kept by default and how to keep the intermediate onesfinish
rules inpipeline_documentaion.md
--no-hooks
to all the tests in order to keep checking all the files in the CI tests