Fix two crashes when using websocketpp as a client library #1041
+32
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace references with lib::shared_ptr.
Capture this by shared_ptr in asio callbacks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first part continues fix from PR #539: references to
alogandelogwere fixed (replaced withshared_ptr) but reference torngwas not. Ifrngis accessed afterendpointis destroyed, application crashes.The second part fixes crash in
endpoint::handle_connect()called whenendpointis already destroyed. The fix is to captureshared_ptrinstead of rawthispointer (similar to callbacks inconnection).The crashes occurred regularly in automated tests for application that creates and destroys
endpointfor each client connection.