Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gpu): add missing synchronize in scalar add, refactor scalar add … #1538

Merged
merged 1 commit into from
Sep 16, 2024
Merged

fix(gpu): add missing synchronize in scalar add, refactor scalar add … #1538

merged 1 commit into from
Sep 16, 2024

Conversation

agnesLeroy
Copy link
Contributor

…on cuda side

closes: please link all relevant issues

PR content/description

Check-list:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Relevant issues are marked as resolved/closed, related issues are linked in the description
  • Check for breaking changes (including serialization changes) and add them to commit message following the conventional commit specification

@cla-bot cla-bot bot added the cla-signed label Sep 12, 2024
@agnesLeroy agnesLeroy added 4090_test Launch test on our CI 4090 desktop and removed cla-signed labels Sep 12, 2024
@agnesLeroy agnesLeroy marked this pull request as ready for review September 12, 2024 16:00
@github-actions github-actions bot removed the 4090_test Launch test on our CI 4090 desktop label Sep 12, 2024
@agnesLeroy agnesLeroy merged commit 9633b61 into main Sep 16, 2024
279 of 300 checks passed
@agnesLeroy agnesLeroy deleted the al/fix_overflowing_scalar_add branch September 16, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbarbakadze bbarbakadze bbarbakadze approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agnesLeroy @bbarbakadze