chore(ci): fix workflows, missing leading $, skipped does not exist

- avoid spamming if cancelled
zama-ai · Mar 4, 2024 · 601b200 · 601b200
1 parent a0d5bf2
commit 601b200
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 14 deletions.
diff --git a/.github/workflows/gpu_4090_full_benchmark.yml b/.github/workflows/gpu_4090_full_benchmark.yml
@@ -18,7 +18,7 @@ on:
     types: [labeled]
   schedule:
     # Weekly benchmarks will be triggered each Friday at 9p.m.
-    - cron: '0 21 * * 5'
+    - cron: "0 21 * * 5"
 
 jobs:
   cuda-integer-benchmarks:
@@ -28,13 +28,13 @@ jobs:
       group: ${{ github.workflow }}_${{ github.ref }}_cuda_integer_bench
       cancel-in-progress: true
     runs-on: ["self-hosted", "4090-desktop"]
-    timeout-minutes: 1440  # 24 hours
+    timeout-minutes: 1440 # 24 hours
     strategy:
       fail-fast: false
       max-parallel: 1
       matrix:
-        command: [ integer, integer_multi_bit]
-        op_flavor: [ default, unchecked ]
+        command: [integer, integer_multi_bit]
+        op_flavor: [default, unchecked]
 
     steps:
       - name: Checkout tfhe-rs
@@ -113,7 +113,7 @@ jobs:
       group: ${{ github.workflow }}_${{ github.ref }}_cuda_core_crypto_bench
       cancel-in-progress: true
     runs-on: ["self-hosted", "4090-desktop"]
-    timeout-minutes: 1440  # 24 hours
+    timeout-minutes: 1440 # 24 hours
 
     steps:
       - name: Checkout tfhe-rs
@@ -178,7 +178,7 @@ jobs:
           ${{ secrets.SLAB_URL }}
 
       - name: Slack Notification
-        if: {{ !success() && !skipped() }}
+        if: ${{ !success() && !cancelled() }}
         continue-on-error: true
         uses: rtCamp/action-slack-notify@b24d75fe0e728a4bf9fc42ee217caa686d141ee8
         env:
@@ -187,7 +187,7 @@ jobs:
 
   remove_github_label:
     name: Remove 4090 bench label
-    if: ${{ github.event_name == 'pull_request' }} 
+    if: ${{ github.event_name == 'pull_request' }}
     needs: [cuda-integer-benchmarks, cuda-core-crypto-benchmarks]
     runs-on: ["self-hosted", "4090-desktop"]
     steps:

diff --git a/.github/workflows/integer_gpu_benchmark.yml b/.github/workflows/integer_gpu_benchmark.yml
@@ -145,7 +145,7 @@ jobs:
           ${{ secrets.SLAB_URL }}
 
       - name: Slack Notification
-        if: {{ !success() && !skipped() }}
+        if: ${{ !success() && !cancelled() }}
         continue-on-error: true
         uses: rtCamp/action-slack-notify@b24d75fe0e728a4bf9fc42ee217caa686d141ee8
         env:

diff --git a/.github/workflows/integer_gpu_full_benchmark.yml b/.github/workflows/integer_gpu_full_benchmark.yml
@@ -38,15 +38,15 @@ jobs:
   integer-benchmarks:
     name: Execute integer benchmarks for all operations flavor
     runs-on: ${{ github.event.inputs.runner_name }}
-    timeout-minutes: 1440  # 24 hours
+    timeout-minutes: 1440 # 24 hours
     if: ${{ !cancelled() }}
     continue-on-error: true
     strategy:
       fail-fast: false
       max-parallel: 1
       matrix:
-        command: [ integer, integer_multi_bit]
-        op_flavor: [ default, unchecked ]
+        command: [integer, integer_multi_bit]
+        op_flavor: [default, unchecked]
         # explicit include-based build matrix, of known valid options
         include:
           - os: ubuntu-22.04
@@ -148,7 +148,7 @@ jobs:
   slack-notification:
     name: Slack Notification
     runs-on: ${{ github.event.inputs.runner_name }}
-    if: {{ !success() && !skipped() }}
+    if: ${{ !success() && !cancelled() }}
     needs: integer-benchmarks
     steps:
       - name: Notify

diff --git a/.github/workflows/integer_multi_bit_gpu_benchmark.yml b/.github/workflows/integer_multi_bit_gpu_benchmark.yml
@@ -31,7 +31,7 @@ jobs:
   cuda-integer-benchmarks:
     name: Execute integer multi-bit benchmarks in EC2
     runs-on: ${{ github.event.inputs.runner_name }}
-    timeout-minutes: 1440  # 24 hours
+    timeout-minutes: 1440 # 24 hours
     if: ${{ !cancelled() }}
     strategy:
       fail-fast: false
@@ -146,7 +146,7 @@ jobs:
           ${{ secrets.SLAB_URL }}
 
       - name: Slack Notification
-        if: {{ !success() && !skipped() }}
+        if: ${{ !success() && !cancelled() }}
         continue-on-error: true
         uses: rtCamp/action-slack-notify@b24d75fe0e728a4bf9fc42ee217caa686d141ee8
         env: