Skip to content
This repository has been archived by the owner on Apr 22, 2020. It is now read-only.

Metrics sampling #382

Merged
merged 14 commits into from
Dec 6, 2018
Merged

Metrics sampling #382

merged 14 commits into from
Dec 6, 2018

Conversation

mohabusama
Copy link
Contributor

  • Sampling can be used by ZMON backend to throttle certain account metrics ingestion
  • Method used: random non-uniform sampling

Resolve #380

- Sampling can be used by ZMON backend to throttle certain account metrics ingestion
- Method used: random non-uniform sampling
Signed-off-by: Mohab Usama <[email protected]>
@codecov
Copy link

codecov bot commented Nov 29, 2018

Codecov Report

Merging #382 into master will decrease coverage by 0.05%.
The diff coverage is 72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #382      +/-   ##
==========================================
- Coverage   75.33%   75.28%   -0.06%     
==========================================
  Files          80       80              
  Lines        5819     5887      +68     
==========================================
+ Hits         4384     4432      +48     
- Misses       1435     1455      +20
Impacted Files Coverage Δ
zmon_worker_monitor/zmon_worker/tasks/main.py 75.55% <100%> (+0.82%) ⬆️
zmon_worker_monitor/tasks.py 75% <50%> (ø) ⬆️
zmon_worker_monitor/workflow.py 67.87% <51.21%> (-3.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7934d63...e4dc705. Read the comment docs.

Signed-off-by: Mohab Usama <[email protected]>
Signed-off-by: Mohab Usama <[email protected]>
Signed-off-by: Mohab Usama <[email protected]>
Signed-off-by: Mohab Usama <[email protected]>
Signed-off-by: Mohab Usama <[email protected]>
Signed-off-by: Mohab Usama <[email protected]>
Signed-off-by: Mohab Usama <[email protected]>
Signed-off-by: Mohab Usama <[email protected]>
Signed-off-by: Mohab Usama <[email protected]>
@vetinari
Copy link
Contributor

vetinari commented Dec 6, 2018

👍

1 similar comment
@mohabusama
Copy link
Contributor Author

👍

@mohabusama mohabusama merged commit 18b77ff into master Dec 6, 2018
@mohabusama mohabusama deleted the metrics-sampling branch December 6, 2018 12:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants