-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for traffic segments. #495
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rodrigo Reis <[email protected]>
Signed-off-by: Rodrigo Reis <[email protected]>
…dates. Signed-off-by: Rodrigo Reis <[email protected]>
Signed-off-by: Rodrigo Reis <[email protected]>
Signed-off-by: Rodrigo Reis <[email protected]>
Signed-off-by: Rodrigo Reis <[email protected]>
Signed-off-by: Rodrigo Reis <[email protected]>
Signed-off-by: Rodrigo Reis <[email protected]>
Signed-off-by: Rodrigo Reis <[email protected]>
Signed-off-by: Rodrigo Reis <[email protected]>
Signed-off-by: Rodrigo Reis <[email protected]>
Signed-off-by: Rodrigo Reis <[email protected]>
Signed-off-by: Rodrigo Reis <[email protected]>
Signed-off-by: Rodrigo Reis <[email protected]>
Signed-off-by: Rodrigo Reis <[email protected]>
Signed-off-by: Rodrigo Reis <[email protected]>
Signed-off-by: Rodrigo Reis <[email protected]>
…uteGroup to Ingress (and vice-versa) E2Es Signed-off-by: Rodrigo Reis <[email protected]>
Signed-off-by: Rodrigo Reis <[email protected]>
Signed-off-by: Rodrigo Reis <[email protected]>
Signed-off-by: Rodrigo Reis <[email protected]>
Signed-off-by: Rodrigo Reis <[email protected]>
Signed-off-by: Rodrigo Reis <[email protected]>
Signed-off-by: Rodrigo Reis <[email protected]>
Signed-off-by: Rodrigo Reis <[email protected]>
mikkeloscar
reviewed
Nov 10, 2023
mikkeloscar
reviewed
Nov 10, 2023
mikkeloscar
reviewed
Nov 10, 2023
mikkeloscar
reviewed
Nov 10, 2023
mikkeloscar
reviewed
Nov 24, 2023
mikkeloscar
reviewed
Nov 24, 2023
Signed-off-by: Mikkel Oscar Lyderik Larsen <[email protected]>
…etely disable segments.
mikkeloscar
reviewed
Dec 14, 2023
mikkeloscar
reviewed
Dec 14, 2023
mikkeloscar
reviewed
Dec 14, 2023
👍 |
1 similar comment
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request (PR) adds support for traffic management through the use of
Skipper's TrafficSegment predicate. By default this feature is not active for
StackSets, and can be activated/controlled in the following way:
"stackset-controller.zalando.org/use-traffic-segments": "true"
, the controller will manage ingress/routegroup and traffic with a dedicated resource per stack (a Ingress/RouteGroup segment), usingTrafficSegment
to split traffic. This annotation is only active when you start the controller with both--enable-traffic-segments
and--annotated-traffic-segments
set."stackset-controller.zalando.org/use-traffic-segments": "true"
, the controllerwill convert the StackSet to use
TrafficSegment
in the following way:corresponding to each Stack traffic weight.
per Stack segments.
--enable-traffic-segments
enables by default traffic segments on all StackSets. In this mode the controller will also convert StackSets using a central ingress resource as described above.--enable-traffic-segments
and--annotated-traffic-segments
enables traffic segments only on StzasckSets with the annotation"stackset-controller.zalando.org/use-traffic-segments": "true"
.On StackSets with traffic segments, the controller switches traffic one segment
at a time, prioritizing first stacks with a higher increase in traffic share.
This PR also updates end 2 end tests to repeat the same tests also with StackSets with explicit support for Traffic Segments.
Finally, this PR removes deprecated
varcheck
anddeadcode
linters,already covered by
unused
.