Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: Add ContentPages and Invoke(sender) #395

Merged
merged 12 commits into from
Feb 3, 2025

Conversation

zadjii-msft
Copy link
Owner

@zadjii-msft zadjii-msft commented Feb 3, 2025

BREAKING API CHANGES APPROACHING

Closes #307
Closes #238
Removes Command from ITag
Adds IDetailsCommand (to achieve the same goal as the above originally had)
Adds ITreeContent, based on a hunch
Adds ShowToast and Confirm to CommandResult too, but without UX yet

Extensions from before this change will need to be updated.

  • The InvokableCommand change should be trivial - the helpers should abstract that delta away for you.
  • The ContentPage change should be pretty easy to make.
    • Both MarkdownPage and FormPage are now just ContentPage
    • FormPage.Forms() -> ContentPage.GetContent()
    • MarkdownPage.Bodies() -> ContentPage.GetContent()
    • IForms become IFormContent. Methods become properties (not that bad)
  • I'm only deprecating the old Markdown and Form pages - I'll fully remove them before we OSS, but I'll give everyone a couple weeks to port them.
  • No one was using Tag.Command and it always seemed iffy at best - better not.

@zadjii-msft zadjii-msft added the Area-API Anything having to do with the actual interface the extensions use to communicate with the host label Feb 3, 2025

This comment has been minimized.

…and-invokes

# Conflicts:
#	src/modules/cmdpal/Microsoft.CmdPal.UI/Microsoft.CmdPal.UI.csproj
@zadjii-msft zadjii-msft merged commit edb6145 into main Feb 3, 2025
6 checks passed
@zadjii-msft zadjii-msft deleted the dev/migrie/f/content-and-invokes branch February 3, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-API Anything having to do with the actual interface the extensions use to communicate with the host
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate IInvokableCommand.Invoke(object sender) Add an IContentPage
1 participant