forked from microsoft/PowerToys
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING: Add ContentPages and Invoke(sender) #395
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zadjii-msft
added
the
Area-API
Anything having to do with the actual interface the extensions use to communicate with the host
label
Feb 3, 2025
This comment has been minimized.
This comment has been minimized.
…and-invokes # Conflicts: # src/modules/cmdpal/Microsoft.CmdPal.UI/Microsoft.CmdPal.UI.csproj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area-API
Anything having to do with the actual interface the extensions use to communicate with the host
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING API CHANGES APPROACHING
Closes #307
Closes #238
Removes
Command
fromITag
Adds
IDetailsCommand
(to achieve the same goal as the above originally had)Adds
ITreeContent
, based on a hunchAdds
ShowToast
andConfirm
toCommandResult
too, but without UX yetExtensions from before this change will need to be updated.
InvokableCommand
change should be trivial - the helpers should abstract that delta away for you.ContentPage
change should be pretty easy to make.MarkdownPage
andFormPage
are now justContentPage
FormPage.Forms()
->ContentPage.GetContent()
MarkdownPage.Bodies()
->ContentPage.GetContent()
IForm
s becomeIFormContent
. Methods become properties (not that bad)Tag.Command
and it always seemed iffy at best - better not.