-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Microsoft Learn Extension #386
base: main
Are you sure you want to change the base?
Conversation
Seems like list isn't updating itself
src/modules/cmdpal/Exts/MicrosoftLearnExtension/Pages/MicrosoftLearnExtensionPage.cs
Dismissed
Show dismissed
Hide dismissed
server.RegisterExtension(() => extensionInstance); | ||
|
||
// This will make the main thread wait until the event is signalled by the extension class. | ||
// Since we have single instance of the extension object, we exit as sooon as it is disposed. |
Check failure
Code scanning / check-spelling
Unrecognized Spelling
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details.Unrecognized words (1)devrel To accept these unrecognized words as correct, you could run the following commands... in a clone of the [email protected]:zadjii-msft/PowerToys.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.24/apply.pl' |
perl - 'https://github.com/zadjii-msft/PowerToys/actions/runs/13064179707/attempts/1'
OR To have the bot accept them for you, comment in the PR quoting the following line: Errors (1)See the 📂 files view, the 📜action log, or 📝 job summary for details.
See ❌ Event descriptions for more information. If the flagged items are 🤯 false positivesIf items relate to a ...
|
public override void UpdateSearchText(string oldSearch, string newSearch) | ||
{ | ||
IsLoading = true; | ||
GetItems(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO I would do the search here, build the results, cache them into a member, then RaiseItemsChanged
. Then in GetItems()
, just return the cached member
Summary of the Pull Request
This PR brings in my hackathon test extension to search the Microsoft Learn Docs. It basically encodes this search form into an extension (that's the goal): https://learn.microsoft.com/en-us/search/?terms=ComboBox
The current implementation searches a specific product (Windows App SDK docs).
It almost works again with the latest in main (it compiles), but seems like displayed results are delayed. Though I haven't completely updated the pattern as per some other samples yet, so I'm probably doing something wrong there?
Need a pointer to example settings as well, as I need a toggle settings for the doc product areas (guids) to include in searches and a combobox for content area.
TODO
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed