Actual request warning for Django cache_page

.gitignore

@@ -16,3 +16,4 @@ MANIFEST
 .*.swo
 /build
 .coverage
+.pytest_cache

ring/django.py

@@ -3,6 +3,7 @@
 """
 from __future__ import absolute_import
 
+import warnings
 from typing import Any, Optional, Tuple
 from django.core import cache as django_cache
 from django.http.request import HttpRequest
@@ -50,16 +51,18 @@ def transform_cache_page_args(wire, rules, args, kwargs):
             raise TypeError
         request = HttpRequest()
         request.__dict__.update(template_request.__dict__)
+        request._fake_request = True
         request.method = 'GET'
-        try:
-            path = reverse(path_hint)
-        except NoReverseMatch:
-            path = path_hint
-        request.path = path
+        if path_hint is not None:
+            try:
+                path = reverse(path_hint)
+            except NoReverseMatch:
+                path = path_hint
+            request.path = path
     else:
         request = raw_request  # type error?
 
-    return (request,) + args[1:], kwargs
+    return (request, ) + args[1:], kwargs
 
 
 class CachePageUserInterface(fbase.BaseUserInterface):
@@ -157,8 +160,14 @@ def get_or_update(self, wire, request, *args, **kwargs):
 
     @fbase.interface_attrs(
         transform_args=transform_cache_page_args, return_annotation=None)
-    def delete(self, *args, **kwargs):
-        key_get, key_head = self.key(*args, **kwargs)
+    def delete(self, wire, request, *args, **kwargs):
+        if not getattr(request, '_fake_request', None):
+            warnings.warn(
+                "A request is given as first argument. If this is intended "
+                "try '(request, None)'. Otherwise, Use '(request, path)' "
+                "instead of 'request' to convert the actual request to have "
+                "the target path.")
+        key_get, key_head = self.key(wire, request, *args, **kwargs)
         if key_get:
             self.middleware.cache.delete(key_get)
         if key_head:

setup.py

@@ -7,8 +7,10 @@
 def get_version():
     with open('ring/__version__.py') as f:
         empty, version = f.read().split('__version__ = ')
-        assert empty == ''
-        version = version.strip()
+    assert empty == ''
+    version = version.strip().strip("'")
+    assert version.startswith('0.')
+    return version
 
 
 install_requires = [
@@ -93,9 +95,7 @@ def get_readme():
     packages=(
         'ring',
     ),
-    package_data={
-        'ring': ['version.txt'],
-    },
+    package_data={},
     install_requires=install_requires,
     tests_require=tests_require + ['tox', 'tox-pyenv'],
     extras_require={

tests/test_django.py

@@ -50,7 +50,7 @@ def view_func(request):
     request_factory = RequestFactory()
     request_main = functools.partial(request_factory.get, '/ring')
 
-    view_func.delete(request_main())
+    view_func.delete((request_main(), None))
     response = view_func.get(request_main())
     assert response is None  # not cached
 
@@ -85,7 +85,7 @@ def view_func(request):
     with pytest.raises(NotImplementedError):
         view_func.has(request_main())
 
-    view_func.delete(request_main())  # delete
+    view_func.delete((request_main(), None))  # delete
 
     response = view_func.get(request_main())
     assert response is None  # no cache anymore
@@ -139,7 +139,6 @@ def test_django_chaining():
 
 
 def test_django_invalid_reverse():
-
     request_factory = RequestFactory()
     request = request_factory.get('/chain/new')
 

tox.ini

@@ -1,5 +1,5 @@
 [tox]
-envlist = py27,py33,py34,py35,py36,pypy2,pypy3
+envlist = py27,py34,py35,py36,pypy2,pypy3
 [testenv]
 deps=
     pytest