Enable websocket cross-origin while ws_origin is set as "" #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Dai,
Gotty is an awesome project and I like it very much, but it seems that there is something unexpected, maybe.
By design , if the flag "ws_origin" is set as "", there should be no cross-origin check for websocket.
But actually if we pass a nil function as CheckOrigin for websocket.Upgradter, the host in the Origin header must not be set or must match the host of the request.
So my change is, if "ws_origin" is set as "", ChechOrigin will be a func who always return true.
Please kindly correct me if my usage went wrong.
BR,
Ye Jianquan