drop default JAVA_HOME from SparkLauncher #31
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faucct
force-pushed
the
feature/drop-default-JAVA_HOME-from-SparkLauncher
branch
from
6564288 to
384a5bf
Compare
alextokarew
requested changes
Oct 1, 2024
|
|
||
| private val livyHome: String = absolutePath(env("LIVY_HOME", "./livy")) | ||
|
|
||
| private val javaHome: String = absolutePath(env("JAVA_HOME", null)) |
There was a problem hiding this comment.
Why JAVA_HOME is set to null by default?
There was a problem hiding this comment.
So working java executable would not be broken by a non-existent /opt/jdk11 path.
| val startProcess = Process( | ||
| livyRunner, | ||
| new File("."), | ||
| val extraEnv = ArrayBuffer( | ||
| "SPARK_HOME" -> sparkHome, |
There was a problem hiding this comment.
Actually, you're not dropping SPARK_HOME, as you wrote in changeset description.
There was a problem hiding this comment.
My bad, has renamed the PR.
faucct
changed the title
alextokarew
approved these changes
Oct 8, 2024
|
@alextokarew has imported your pull request. If you are a Yandex employee, you can view this diff. |
|
✅ This pull request is being closed because it has been successfully merged into our internal monorepository. |
robot-piglet
pushed a commit
that referenced
this pull request
Oct 8, 2024
This forces the java to be at specific path, though it is probably enough for it to be resolvable via `$PATH`. --- Pull Request resolved: #31 commit_hash:ac3400c8fb8931aab3afbd099c82b21c72ac7999
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This forces the java to be at specific path, though it is probably enough for it to be resolvable via
$PATH.