cxx, macro typo. missing the comma ;

yssource · May 5, 2022 · 8ff9800 · 8ff9800
1 parent 8b3735a
commit 8ff9800
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 3 deletions.
diff --git a/.clang-tidy b/.clang-tidy
@@ -29,3 +29,5 @@ CheckOptions:
     value:           '10'
   - key:             google-readability-namespace-comments.SpacesBeforeComments
     value:           '2'
+  - key:             modernize-loop-convert.NamingStyle
+    value:           CamelCase
diff --git a/.gitignore b/.gitignore
@@ -111,8 +111,8 @@ ENV/
 /cxx.sql/
 /cxx/public/
 /cxx/views/
-/**/cbuild*/
-/**/q*build*/
+cbuild/
+qbuild/
 tmp/
 build-main*/
 *.pro.user
@@ -138,3 +138,5 @@ Pipfile.lock
 
 # premium data source
 /abquant/data/premium/
+
+tags
diff --git a/conanfile.py b/conanfile.py
@@ -64,6 +64,10 @@ def config_options(self):
         if self.settings.os == "Windows":
             del self.options.fPIC
 
+    def configure(self):
+        if self.options.shared:
+            del self.options.fPIC
+
     # def build_requirements(self):
     #     self.build_requires("cmake/3.20.3")
     #     self.build_requires("ninja/1.10.2")

diff --git a/cxx/src/actions/utils.hpp b/cxx/src/actions/utils.hpp
@@ -166,6 +166,6 @@ using is_base_of_template = typename is_base_of_template_impl<base, derived>::ty
             QString msg = QString(col) + QString(" series are not available here.");                                 \
             throw std::runtime_error(msg.toStdString());                                                             \
         }                                                                                                            \
-    } while (false)
+    } while (false);
 
 } // namespace abq