Chip 구현 #25
Open
Chip 구현 #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yourssu/android-maintainer 이걸로 리뷰어 요청하시면 됩니다! |
cometj03
reviewed
Dec 31, 2024
Comment on lines
+37
to
+40
| fun Chip( | ||
| onCheckedChange: (Boolean) -> Unit, | ||
| modifier: Modifier = Modifier, | ||
| text: String, |
There was a problem hiding this comment.
onCheckedChange에도 기본 값을 두는 게 어떨까요?
HI-JIN2
approved these changes
Dec 31, 2024
Comment on lines
+17
to
+19
| val iconSize: IconSize = IconSize.XS, | ||
| val horizontalPadding: Dp = 12.dp, | ||
| val round: Dp = 40.dp |
There was a problem hiding this comment.
이 부분이 chip의 사이즈에 영향을 받지 않는 부분이라면 파일 맨 끝에 아래와 같이 명시 하는게 어떠할까요? 상수 값을 따로 뺀다면 sealed class여야 할 이유도 없어 보입니다..! 지금도 너무 좋은 코드지만, 다른 핸디 컴포넌트 구현들과 구조를 맞추는게 좋지 아니할까 싶습니닷..!!
object DialogDefaults {
val dialogWidth = 296.dp
val dialogPadding = 20.dp
val dialogInsidePadding = 16.dp
val dialogButtonSpacing = 8.dp
}
There was a problem hiding this comment.
기존에 구현된 컴포넌트 코드를 보니, 사이즈에 따라 타이포나 아이콘 사이즈 등이 달라지는 경우에는 sealed class, 단순 size 구분에는 enum class를 사용한 걸로 파악이 됩니다!
Comment on lines
+38
to
+40
| onCheckedChange: (Boolean) -> Unit, | ||
| modifier: Modifier = Modifier, | ||
| text: String, |
There was a problem hiding this comment.
기본값이 없는 파라미터(필수 파라미터)의 경우 modifier보다 위에 두는 것을 권장합니다! 기본값이 있는 optional 파라미터는 modifier 밑으로 두면됩니다
Suggested change
| onCheckedChange: (Boolean) -> Unit, | |
| modifier: Modifier = Modifier, | |
| text: String, | |
| onCheckedChange: (Boolean) -> Unit, | |
| text: String, | |
| modifier: Modifier = Modifier, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Chip을 구현하였습니다.
Describe your changes