Dialog 구현 #21
Open
Dialog 구현 #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cometj03
reviewed
Dec 13, 2024
| buttonType = BoxButtonType.Secondary | ||
| ) | ||
|
|
||
| Spacer(modifier = modifier.width(dialogButtonSpacing)) |
There was a problem hiding this comment.
Suggested change
| Spacer(modifier = modifier.width(dialogButtonSpacing)) | |
| Spacer(modifier = Modifier.width(dialogButtonSpacing)) |
| ) { | ||
| // Scrim | ||
| Box( | ||
| modifier = Modifier |
There was a problem hiding this comment.
Suggested change
| modifier = Modifier | |
| modifier = modifier |
특별한 이유가 있지 않다면 파라미터로 들어오는 modifier는 최상위 컴포저블에만 적용하고 나머지는 파라미터와 독립적으로 적용하는 게 관례예요
| contentAlignment = Alignment.Center // 중앙 정렬 | ||
| ) { | ||
| Box( | ||
| modifier = modifier |
There was a problem hiding this comment.
Suggested change
| modifier = modifier | |
| modifier = Modifier |
등등
Comment on lines
68
to
71
| .background( | ||
| color = HandyTheme.colors.bgBasicDefault, | ||
| shape = RoundedCornerShape(16.dp) | ||
| ) //todo Radius.XL 어떻게 활용하는지 모르겠음 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
구현
영상
default.webm
ToReviewer
Scrim
해당 컬러가 다이얼로그 사용시 scrim과 함께 사용하며 scrim은 opacity/gray를 사용합니다.애니메이션