Add testnet support for transaction links, corrected whatsonchain variable name #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danwag06
requested changes
Jan 8, 2025
| @@ -132,6 +132,7 @@ export const TxHistory = (props: TxHistoryProps) => { | |||
| const itemsPerPage = 25; | |||
| const { gorillaPoolService, chromeStorageService } = useServiceContext(); | |||
| const [expandedRows, setExpandedRows] = useState<Set<string>>(new Set()); | |||
| const isTestnet = chromeStorageService.getNetwork() === 'testnet'; | |||
There was a problem hiding this comment.
Instead of 'testnet' let's use the enum for consistency...
NetWork.Testnet imported from 'yours-wallet-provider'
There was a problem hiding this comment.
We're pushing a new update so will address this myself with new changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testnet transaction history was linking to the normal whatsonchain.com site not the test.whatsonchain.com site.
Also corrected variables to whatsonchain.