Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

fix: QS tile related issues #283

Merged
merged 2 commits into from
Apr 8, 2024
Merged

fix: QS tile related issues #283

merged 2 commits into from
Apr 8, 2024

Conversation

SuhasDissa
Copy link
Member

@SuhasDissa SuhasDissa commented Apr 6, 2024

fix #280

This PR also makes it possible to start a screen recording/audio recording when the app is in the foreground.

@Bnyro
Copy link
Member

Bnyro commented Apr 6, 2024

Maybe we could show a dialog asking for the permissions with some information about why it's needed for the quick tiles and that they won't work otherwise? (Of course granting the permissions must stay optional, but we can at least tell users that they're needed before they run into issues)

@SuhasDissa
Copy link
Member Author

Now the overlay permission will be granted automatically

@Bnyro
Copy link
Member

Bnyro commented Apr 7, 2024

I think we still need to request the display over other apps permission manually on Android 11 and above?

How's that supposed to work without them?

@SuhasDissa
Copy link
Member Author

I think we still need to request the display over other apps permission manually on Android 11 and above?

How's that supposed to work without them?

android.permission.SYSTEM_ALERT_WINDOW will automatically be granted when running getMediaProjection()

@SuhasDissa SuhasDissa merged commit 3850194 into you-apps:main Apr 8, 2024
1 check passed
@SuhasDissa SuhasDissa deleted the qs branch May 12, 2024 05:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

app launches when trying to start screen recording via quick settings toggle
2 participants