This repository has been archived by the owner on Aug 7, 2024. It is now read-only.
Allow high quality opus recording #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Opus codec supports low latency and high quality audio recording. I think we should make more reasonable defaults and allow more fine grained control for people who know what they are doing. Another stab at fixing you-apps#193. Since you-apps#235 as an addition to disabling sample rate control setting up the bitrate is no longer working for opus file recordings. These sample rates are natively supported by the opus encoder with no resampling involved: 8, 12, 16, 24, or 48 kHz. See this FAQ answer and a few follow up answers https://wiki.xiph.org/OpusFAQ#What_is_Opus_Custom? When not specifying the sample rate at all resulting files have some kind of default sample rate that severely degrades audio quality. When inspecting files with ffmpeg the sample rate is always displayed as 48000. I have verified that setting the sample rate it increases audio quality though. Changes based off of this: * Again respect bitrate setting when recording into opus. Bitrate of 32000, 40000 or 48000 sound very goot for casual recordings sampled at 48000 Hz. * Allow setting sample rate for opus encoding when specifying one of the supported values.
Bnyro
reviewed
Mar 11, 2024
| if (audioFormat.codec != MediaRecorder.AudioEncoder.OPUS) { | ||
| Preferences.prefs.getInt(Preferences.audioSampleRateKey, -1).takeIf { it > 0 } | ||
| ?.let { | ||
| Preferences.prefs.getInt(Preferences.audioSampleRateKey, -1).takeIf { it > 0 } |
There was a problem hiding this comment.
We should extract this and the bitrate preference to variables first, that would make things cleaner.
There was a problem hiding this comment.
Bitrate preference is exactly as all the other preferences even before the issue with opus recording was discovered so I haven't yet touched that one. If you insist I will change that of course.
As for the sample rate I have extracted it to a variable but I am not sure it's the way you would like to have it. I don't want to introduce more conditions so the change is just minimal.
Bnyro
approved these changes
Mar 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opus codec supports low latency and high quality audio recording. I think we should make more reasonable defaults and allow more fine grained control for people who know what they are doing. Another stab at fixing #193.
Since #235 as an addition to disabling sample rate control setting up the bitrate is no longer working for opus file recordings.
These sample rates are natively supported by the opus encoder with no resampling involved: 8, 12, 16, 24, or 48 kHz. See this FAQ answer and a few follow up answers https://wiki.xiph.org/OpusFAQ#What_is_Opus_Custom?
When not specifying the sample rate at all resulting files have some kind of default sample rate that severely degrades audio quality. When inspecting files with ffmpeg the sample rate is always displayed as 48000. I have verified that setting the sample rate it increases audio quality though. Changes based off of this: