This repository has been archived by the owner on Aug 7, 2024. It is now read-only.
Android 14 related fixes #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pvagner
commented
Mar 6, 2024
pvagner
commented
- Use FOREGROUND_SERVICE_MICROPHONE permission
- Similarly how ScreenRecorderService overrides fgServiceType property to FOREGROUND_SERVICE_TYPE_MEDIA_PROJECTION make both AudioRecorderService and LosslessRecorderService inline with this on android 14 and newer by overriding its fgServiceType to FOREGROUND_SERVICE_TYPE_MICROPHONE.
- RecorderService: When registering receivers use the RECEIVER_EXPORTED flag to avoid security exceptions on Android 14
- ScreenRecorderService: added onStop callback to the MediaProjection. It may possibly fix App doesn't stop recordings when device is powered off resulting in corrupted files #258.
* Use FOREGROUND_SERVICE_MICROPHONE permission * Similarly how ScreenRecorderService overrides fgServiceType property to FOREGROUND_SERVICE_TYPE_MEDIA_PROJECTION make both AudioRecorderService and LosslessRecorderService inline with this on android 14 and newer by overriding its fgServiceType to FOREGROUND_SERVICE_TYPE_MICROPHONE. * RecorderService: When registering receivers use the RECEIVER_EXPORTED flag to avoid security exceptions on Android 14 * ScreenRecorderService: added onStop callback to the MediaProjection. It may possibly fix you-apps#258.
|
Quick tiles can't start foreground services on Android 14 so merging this is not usefull yet. |
Bnyro
reviewed
Mar 11, 2024
app/src/main/java/com/bnyro/recorder/services/RecorderService.kt
Outdated
Show resolved
Hide resolved
Bnyro
reviewed
Mar 11, 2024
app/src/main/java/com/bnyro/recorder/services/RecorderService.kt
Outdated
Show resolved
Hide resolved
Bnyro
reviewed
Mar 11, 2024
Bnyro
reviewed
Mar 11, 2024
Co-authored-by: Bnyro <[email protected]>
Co-authored-by: Bnyro <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.