Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: make sms list live update #353

Merged
merged 1 commit into from
Jan 11, 2024
Merged

refactor: make sms list live update #353

merged 1 commit into from
Jan 11, 2024

Conversation

SuhasDissa
Copy link
Member

@SuhasDissa SuhasDissa commented Dec 21, 2023 •
edited
Loading

Changes:

  • Use coroutine flow for loading sms (from both local and device repositories)
  • Use proper dependency injection for SmsRepository instead of using SmsUtil
  • Move permission related logic into Main Activity

Features:

  • SMS list will update automatically when sending / receiving new messages
sms_live.mp4

@SuhasDissa SuhasDissa marked this pull request as ready for review December 22, 2023 12:36
@SuhasDissa SuhasDissa requested a review from Bnyro December 22, 2023 12:36
@SuhasDissa SuhasDissa changed the title refactor: SMS refactor: make sms list live update Dec 22, 2023
@SuhasDissa SuhasDissa merged commit 48425ad into you-apps:main Jan 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bnyro Bnyro Bnyro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SuhasDissa @Bnyro