Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat: inbuilt dialer including call history #331

Merged
merged 12 commits into from
Apr 25, 2024
Merged

[WIP] feat: inbuilt dialer including call history #331

merged 12 commits into from
Apr 25, 2024

Conversation

Bnyro
Copy link
Member

@Bnyro Bnyro commented Nov 19, 2023

TODO:

  • a button to mute the mic and one to turn the normal speakers on for audio output
  • Dual sim support
  • a notification to get back to the current call
  • In call dialpad
  • Proximity Sensor support
  • testing !!!

NOTES:

  • the minSdk bump is necessary because lower Android versions don't allow to use the InCallService

@Bnyro Bnyro changed the title feat: inbuilt dialer including call history [WIP] feat: inbuilt dialer including call history Nov 19, 2023
@M00NJ
Copy link
Member

M00NJ commented Nov 27, 2023

Some things I noticed while doing some preliminary testing:

  1. Selecting a contact from the contacts tab and clicking on dial doesn't work (nothing happens)
  2. When the phone is not picked up and the call goes to the mailbox, it automatically switches to the AOSP phone app and the call is continued there (really strange)
  3. There's no way to delete calls (swipe to dismiss and a 'clear all' button would make sense here)
  4. The dialer screen persists after hanging up (you need to minimise or close the app to go back)

Some other things we should considers:

  • Implement search in the phone tab as well
    (ATM with the dial button not working there's no way to select a contact that you haven't called recently, so you'll have to know the number and dial it.)
  • Use a list instead of cards
    (I mentioned this already for the contacts tab, but it applies even more so here. If we're listing items we should use a list 😅. So many cards on screen make the UI look cramped IMO and waste vertical space, where there might fit another contact on screen.)

This is really exiting :). I'm also surprised by how good the call quality is. I hope I'll be more free in the coming weeks so I can do more testing and help with this as well...

@Bnyro Bnyro mentioned this pull request Dec 3, 2023
3 tasks
SuhasDissa and others added 7 commits December 8, 2023 14:55
fix: dialer screen crashing
# Conflicts:
#	app/src/main/AndroidManifest.xml
#	app/src/main/java/com/bnyro/contacts/ui/activities/MainActivity.kt
#	app/src/main/java/com/bnyro/contacts/ui/screens/MainAppContent.kt
#	app/src/main/java/com/bnyro/contacts/ui/screens/SettingsScreen.kt
#	app/src/main/res/values/strings.xml
@Gamer750

This comment was marked as off-topic.

@SuhasDissa
Copy link
Member

I think it will be easier if we could merge this PR now and work on the other features after merging.
Integrating contacts with the dialer will probably require some refactoring, which could cause merge conflicts.

Apart from that, I believe that the dialer is stable enough to mark as an experimental opt-in feature.

@Bnyro
Copy link
Member Author

Bnyro commented Apr 25, 2024

I agree on that, let's merge 👍

Before creating a new release we can just make a preference to opt-in for using it.

@Bnyro Bnyro merged commit 670595d into main Apr 25, 2024
2 checks passed
@Bnyro Bnyro deleted the dialer branch April 25, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants