-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] feat: inbuilt dialer including call history #331
Conversation
Some things I noticed while doing some preliminary testing:
Some other things we should considers:
This is really exiting :). I'm also surprised by how good the call quality is. I hope I'll be more free in the coming weeks so I can do more testing and help with this as well... |
style: improve dialer design
fix: dialer screen crashing
# Conflicts: # app/src/main/AndroidManifest.xml # app/src/main/java/com/bnyro/contacts/ui/activities/MainActivity.kt # app/src/main/java/com/bnyro/contacts/ui/screens/MainAppContent.kt # app/src/main/java/com/bnyro/contacts/ui/screens/SettingsScreen.kt # app/src/main/res/values/strings.xml
This comment was marked as off-topic.
This comment was marked as off-topic.
I think it will be easier if we could merge this PR now and work on the other features after merging. Apart from that, I believe that the dialer is stable enough to mark as an experimental opt-in feature. |
I agree on that, let's merge 👍 Before creating a new release we can just make a preference to opt-in for using it. |
TODO:
NOTES: