Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last declaration in a block does not require a semicolon #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Last declaration in a block does not require a semicolon #25

wants to merge 1 commit into from

Conversation

mccutchen
Copy link

Hi,

I've just started using Spritemapper as a part of my assset-building pipeline, and I've run into an issue with its CSS parsing. It raises a RuntimeError when the last declaration in a block is not terminated by a semicolon, but I don't believe that should be an error according to the spec.

I ran into this because my current pipeline goes

Sass compiler => YUI Compressor => Spritemapper

and the YUI Compressor always removes the semicolon following the last declaration in a block. I can probably update my pipeline, but I figured I'd submit this minor pull request in the meantime. It's minor mostly because the code was already in place to properly handle this case but was hidden behind the raise RuntimeError... exception.

There must be some reason that exception was put in place, though, so I'm sorry if I'm wasting your time.

Thanks for a great project!

@dotherightthing
Copy link

Yes please, I am trying out spritemapper and also ran into this issue.

@designbyadrian
Copy link

I have this problem too. Easy fix, but at first I was confused by the error. Either fix the requirements, or make the error message more clear that it's a CSS problem and on which line.

Please :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants