Last declaration in a block does not require a semicolon #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've just started using Spritemapper as a part of my assset-building pipeline, and I've run into an issue with its CSS parsing. It raises a
RuntimeError
when the last declaration in a block is not terminated by a semicolon, but I don't believe that should be an error according to the spec.I ran into this because my current pipeline goes
and the YUI Compressor always removes the semicolon following the last declaration in a block. I can probably update my pipeline, but I figured I'd submit this minor pull request in the meantime. It's minor mostly because the code was already in place to properly handle this case but was hidden behind the
raise RuntimeError...
exception.There must be some reason that exception was put in place, though, so I'm sorry if I'm wasting your time.
Thanks for a great project!