Manually track capacity of groups #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheus-consoli
force-pushed
the
better-capacity-for-groups
branch
from
71af035 to
bd57bc4
Compare
yoshuawuyts
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the spiritual successor of #172 (a much simpler implementation)
The problem with using the
Slabcapacity as the group capacity is that the slab has its own growth rate, which differs from the other internal structures. It was possible that the slab had the capacity for more items, but the rest of the structures didn't (I think this was the problem in #168).The solution for this is explicitly tracking the capacity inside the group.
This also provides a new
reservemethod onFuturesGroupandStreamGroup, so the user can prepare the group beforehand to receive more items.Closes #169