Implement no_std tests #159
Merged
+96
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems great; yes please keep going in this direction! |
|
Alright, there is now one test for each trait. I again just reused existing tests so I could easily have missed something. let me know what you think :) |
This commit implements a test for each trait in a no std environment, ensuring compatibility with such an environment. This addresses issue yoshuawuyts#68.
yoshuawuyts
approved these changes
Nov 7, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is a draft PR for #68 to see if I am going in the right direction.
I have taken a test for the
Joinimplementation onarrayand copied it into a no_std environment. I believe this should validate thatJoinworks in ano_stdenvironment.Am I correct in assuming that a single test for
Joinis sufficient? as we are validating that traits work in no_std not specific implementations.Let me know if this is the sort of thing you had in mind :)