Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement Chain for tuples up to 12 elements #124

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

poliorcetics
Copy link
Contributor

I think the index + const pattern I used could be reused for other trait implementations, though I
have not checked.

Also, we could do away with done, it's enough to check this.index == $mod_name::LEN in the assert!, but
without benchmarking I'm not sure which is better, especially since adding a single bool is unlikely to be costly
since the futures will probably be much heavier than it.

Helps with #62.

@poliorcetics
Copy link
Contributor Author

Trivia: this MR is exactly twice the number of the issue it is working on, which is useless but makes me smile :D

Copy link
Owner

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@yoshuawuyts yoshuawuyts merged commit e3bfd0f into yoshuawuyts:main Apr 5, 2023
@poliorcetics poliorcetics deleted the chain-tuple branch April 5, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants