Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement better capacity in our group structures #169

Closed
yoshuawuyts opened this issue Mar 19, 2024 · 2 comments · Fixed by #177
Closed

Implement better capacity in our group structures #169

yoshuawuyts opened this issue Mar 19, 2024 · 2 comments · Fixed by #177
Assignees
Labels
bug Something isn't working

Comments

@yoshuawuyts
Copy link
Owner

#168 fixes the immediate insertion time issues of FutureGroup::insert - however the code is, how should I say this, not great?

We need to implement our own exponential capacity algorithm. This means implementing a reserve method which ensures there is enough capacity. And then making sure that if we run out of capacity we always double our space. We may even want to rename some of our existing resize methods to reserve, since they don't take items where Vec::resize does.

This probably needs to be an immediate follow-up to #168; I don't think we should release a new version without it.

@yoshuawuyts
Copy link
Owner Author

yoshuawuyts commented Apr 12, 2024

Porting my comment from #175:

@matheus-consoli are you still ok to file that PR? If not, feel free to re-assign this to me!

@matheus-consoli
Copy link
Collaborator

yes! sorry for the delay, busy week!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants