Fix: 謎のnullチェック

[penginn-net]

What

nullチェック消した

Why

#514 でなぜか追加してた

Additional info (optional)

要らなくない？

Checklist

• コントリビューションガイドを読みました( Read the contribution guide)
• ローカル環境で動作しました(Test working in a local environment)
• (必要なら)CHANGELOG_YOJO.mdの更新((If needed) Update CHANGELOG_YOJO.md)
• (必要なら)テストの追加((If possible) Add tests)

[github-actions]

이 PR에 의한 api.json 차이

차이점은 여기에서 볼 수 있음

--- base
+++ head
@@ -55808,11 +55808,7 @@
                     "type": "string"
                   },
                   "host": {
-                    "type": [
-                      "string",
-                      "null"
-                    ],
-                    "default": null
+                    "type": "string"
                   }
                 },
                 "required": [
@@ -55963,11 +55959,7 @@
                     "type": "string"
                   },
                   "host": {
-                    "type": [
-                      "string",
-                      "null"
-                    ],
-                    "default": null
+                    "type": "string"
                   }
                 },
                 "required": [

Get diff files from Workflow Page

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 40.08%. Comparing base (a183fe0) to head (b407942).
Report is 4 commits behind head on develop.

Files with missing lines	Patch %	Lines
packages/backend/src/server/api/endpoints/emoji.ts	50.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           develop     #563   +/-   ##
========================================
  Coverage    40.08%   40.08%           
========================================
  Files         1696     1696           
  Lines       235633   235675   +42     
  Branches      3930     3947   +17     
========================================
+ Hits         94442    94478   +36     
- Misses      140526   140572   +46     
+ Partials       665      625   -40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kozakura913]

string or nullがnullだったらnullにしてるのか。いらんな

[penginn-net]

これtypecheck落ちるんだ

[kozakura913]

typeormのIsNullはnullではない...?

[penginn-net]

IsNull = undefined
:thinkinghappy:

[kozakura913]

api定義的に見るとnullの方が自然な気がする。host未定義じゃなくて無いじゃん

[kozakura913]

string or null or undefinedでAPI定義されてたのか。うーんstring or nullの方がそれっぽい気がする