Update HtmlReplacer.php

[wilfriedwolf]

Avoids attributes from different tags

[wilfriedwolf]

Solves issue introduced by #83

[hostep]

I think you will also need to update the regex in unmaskAngleBracketsInsideQuotes, as it will also match things you don't want to change: https://regex101.com/r/KsPdmb/1

But in my opinion, this regex solution is a wrong approach to fix #82, it just will cause too many edge case issues as it works on the entire html output of a page. Can't we limit it to only operate on image/picture tags? So that it only applies to html output inside that foreach ($images as $image) { section?

[jissereitsma]

Sorry for not chiming in more quickly. Indeed I overlooked things heavily while merging this PR. On top of this, the integration tests were failing (perhaps also because of other reasons) which is bad as well.

The current fix is still not good enough: What if there is somewhere a quoted part with > in it which should not be converted into >? In other words, @hostep is right that this change should not be temporarily changing strings in the entire HTML, but only in the image tag at hand.

I'm working on this.

[jissereitsma]

I've now added an alternative fix, simply by adding a more complex regex in the right place: 867ef31#diff-56e9cb219161815f1d7336e26a686ab654e4ce468c6cf20463274e162a7b4ffdR116

[hostep]

Thanks Jisse!

[wilfriedwolf]

Thanks from me too, sorry for the inconveniences caused.

[jissereitsma]

No worries, I'm happy that we could work together to improve things!