Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2068 #2080

Merged
merged 2 commits into from
Feb 21, 2025
Merged

Fix #2068 #2080

merged 2 commits into from
Feb 21, 2025

Conversation

yhirose
Copy link
Owner

@yhirose yhirose commented Feb 21, 2025

No description provided.

@yhirose yhirose merged commit 71ba7e7 into master Feb 21, 2025
10 of 11 checks passed
@yhirose yhirose deleted the issue2068 branch February 21, 2025 04:46
@falbrechtskirchinger
Copy link
Contributor

falbrechtskirchinger commented Feb 21, 2025

The problem is that this now masks a clear programmer error. The assertion exists for a reason and should trigger reliably (so it can be seen and fixed).

I can see why users might expect stop() to wait, given that the library blocks in most other situations. stop() would be more accurately named request_stop(). Then, stop() (with a timeout) could wait and return false on timeout.

@yhirose Thoughts?

Ideally, we would add stop(void) calling stop(timeout=0) and mark the former as deprecated, but the library has so far avoided compiler-agnostic macros for such tasks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants