Applied clang-tidy suggestions and export of compile commands for linter support #1794
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The export of the compile commands in the
CMakeLists.txt
, I put them where I think it is fitting. Please adjust how you like if you want to keep.The changes in the source code are minor. There are still suggestions by
clang-tidy
left but I programmed the minor ones. Please take especially a look at the headers I added or removed. I do not not whether the place I put them is correct since you support different environments.The removed ones were not needed. The added ones are needed for the following data types in your source code.
The tests succeed like with commit 548dfff. There happend fails and a segmentation fault but like I said that already happened before so these commits probably did not cause them. I probably have not setup the tests correctly.