Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a getter for a bearer token from a request #1755

Merged
merged 2 commits into from
Jan 15, 2024
Merged

Add a getter for a bearer token from a request #1755

merged 2 commits into from
Jan 15, 2024

Conversation

bugdea1er
Copy link
Contributor

Hi there!

This pr adds a simple getter for bearer token from a request

@yhirose
Copy link
Owner

yhirose commented Jan 15, 2024

@bugdea1er thanks for the pull request. However, I would like to keep Request simple and just include things absolutely necessary.

I am not against adding helper functions for Request as below.

std::string get_bearer_token_auth(const Request &req);

@bugdea1er
Copy link
Contributor Author

@yhirose got it, replaced the method with a helper function

@yhirose yhirose merged commit 4498019 into yhirose:master Jan 15, 2024
4 checks passed
@yhirose
Copy link
Owner

yhirose commented Jan 15, 2024

@bugdea1er thanks for the update!

@bugdea1er bugdea1er deleted the request-token branch January 15, 2024 14:00
zhaokeli pushed a commit to zhaokeli/cpp-httplib that referenced this pull request Oct 10, 2024
* Add a getter for a bearer token from a request

* Replace a method for bearer token getter with a free function

(cherry picked from commit 4498019)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants