Make execute_response's insert_id : int64 option #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To represent the case the insert wasn't performed.
ygrek
approved these changes
Jan 22, 2025
tatchi
reviewed
Feb 1, 2025
| @@ -27,7 +27,7 @@ module type M = sig | |||
| type params | |||
| type row | |||
| type result | |||
| type execute_response = { affected_rows: int64; insert_id: int64 } | |||
| type execute_response = { affected_rows: int64; insert_id: int64 option } | |||
There was a problem hiding this comment.
Should we document that if insert_id is Some x, x is guaranteed to be greater than 0?
There was a problem hiding this comment.
Also, I wonder if we can have insert_id > 0 and affected_rows = 0 (or the other way around). If not, maybe it makes sense to have instead
type execute_response = { affected_rows: int64; insert_id: int64 } optionWhere both affected_rows and insert_id are guaranteed to be greater than 0 🤔
There was a problem hiding this comment.
affected_rows > 0 and insert_id = None When UPDATE or DELETE.
jongleb
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To represent explicitly the case when the insert wasn't performed (can be because of
ON CONFLICTclause for example).