Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contract): add amount_of_proofs in TaskCreated event #1786

Closed
wants to merge 2 commits into from

Conversation

JuArce
Copy link
Collaborator

@JuArce JuArce commented Feb 7, 2025

Add amountOfProofs to TaskCreated evnet in BatcherPaymentService

Description

Caution

This upgrade requires a redeploy of the explorer because the ABI changes. Without redploying the explorer, it won't be able to get the feePerProof values for created batches

This feature may be of help in the future, but at the same time I wouldn't upgrade this contract for only this fix. It may be an acceptable PR if it is redeployed with another BatcherPayments upgrade.

Type of change

Please delete options that are not relevant.

  • New feature
  • Bug fix
  • Optimization
  • Refactor

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@JuArce JuArce closed this Feb 7, 2025
@JuArce JuArce deleted the 1761-amount_of_proofs_in_TaskCreated branch February 7, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants