Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LRS-30 Support LRS 2.0 #22

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

LRS-30 Support LRS 2.0 #22

wants to merge 11 commits into from

Conversation

milt
Copy link
Member

@milt milt commented May 5, 2021

LRS-30
Wherein we strive to be conformant per version "2.0" of the conformance tests:
https://github.com/adlnet/lrs-conformance-test-suite/tree/LRS-2.0

Will require a decent rework to handle both old and new versions, this branch starts that process.

Currently passes 2.0 branch tests in both CLJ and CLJS

Also see: yetanalytics/xapi-schema#73 for the xapi-schema-component

TODO:

  • full dispatch on version (is custom now)
  • Update for release version of tests
  • Fix hack to return 1.0.3 on non-statement routes in interceptor
  • properly destructure and use contextAgents and contextGroups in memory impl
  • pass version to impl
  • add/ensure support for as-yet untested Last-Modified header
  • full backwards compat pending fixes to the 2.0 branch and fixes to master

@milt milt changed the title LRS-30 LRS-30 Support LRS 2.0 May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant