[#1459] do not merge in case .rultor file is in PR #1865
Conversation
pnatashap
commented
Feb 8, 2024
pnatashap
commented
- logic is added
- test is disabled, as MkPull doesn't allow to work with files (too many code to write without it)
|
@yegor256 please take a look |
| } else | ||
| if (pull.allChecksSuccessful()) { | ||
| new Answer(comment).post( | ||
| true, |
There was a problem hiding this comment.
@pnatashap indentation here is definitely wrong (not 4 spaces), but I can't understand why Qulice is not complaining about this...
| @@ -36,6 +36,8 @@ QnMerge.checks-are-failed=Can't merge it. Some CI checks were failed. \ | |||
| Apparently, the pull request is not ready to be \ | |||
| merged since it has some problems. \ | |||
| Please, fix them first. | |||
| QnMerge.system-files-affected=Can't merge it. File `.rultor.yml` is affected by \ | |||
| this pull request. | |||
There was a problem hiding this comment.
@pnatashap would be great if we can explain to the user, why we don't accept modifications to this particular file. Let's say: "Can't merge this pull requests, because the file .rultor.yml was modified. This is a security threat. Make a separate pull request with the modification of this particular file and ask project architect to merge it manually."
There was a problem hiding this comment.
@pnatashap also, I think it's better not to hardcode the name of the file here, but use %s and pass the name of it as a parameter to String.format
| Matchers.containsString( | ||
| QnMergeTest.PHRASES.getString( | ||
| "QnMerge.system-files-affected" | ||
| ) |
There was a problem hiding this comment.
@pnatashap indentations here are also unusual, but Qulice doesn't complain... very strange.
|
@pnatashap many thanks for the contribution! see my comments above |
|
@yegor256 please take a look. |
|
@rultor merge |
