#231 enabling Java 21 syntax using antlr instead of javalang #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lueFlake many thanks for your contribution! I believe, it's a bad practice to keep auto-generated files in Git: https://softwareengineering.stackexchange.com/a/391805/20873 |
|
yeah, for now im keeping it just to show, im planning to implement the autogeneration of these files |
|
@lueFlake got it. We can't merge this PR as is, we have to get rid of the auto-generated files and make sure they are created in runtime. Aside from that, your PR looks excellent! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR i'm trying to replace javalang with antlr to support Java 21+ (ref. #231)