-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented test for ir feature #259
Merged
Merged
Changes from 11 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
496eb87
implemented test for ir feature
zaqbez39me 6a3ee7f
added all the tests to test file
zaqbez39me 8b4d117
Merge branch 'yegor256:master' into ir/test
zaqbez39me 74946aa
Merge branch 'master' into ir/test
zaqbez39me 49f6a9f
Merge branch 'ir/test' of https://github.com/zaqbez39me/cam into ir/test
zaqbez39me 89efb8d
fixed the way of disabling test for ir
zaqbez39me 6eac3e3
disabled shellcheck SC2317
zaqbez39me f338328
added execution permission in git index for test-ir.sh
zaqbez39me 6042687
added empty ir.sh
zaqbez39me c30cd7c
added excutional permition for ir.sh and stub in it
zaqbez39me a2442c6
updated the stub for ir.sh
zaqbez39me 211ea6f
changed expected bahviour for test-ir.sh
zaqbez39me e4d7b4d
fixed todo
zaqbez39me e272ec5
fixed todo in ir.sh
zaqbez39me 4a4db78
merged two TODOs in one
zaqbez39me d88c731
removed TOOO from ir.sh
zaqbez39me File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
#!/usr/bin/env bash | ||
# The MIT License (MIT) | ||
# | ||
# Copyright (c) 2021-2024 Yegor Bugayenko | ||
# | ||
# Permission is hereby granted, free of charge, to any person obtaining a copy | ||
# of this software and associated documentation files (the "Software"), to deal | ||
# in the Software without restriction, including without limitation the rights | ||
# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
# copies of the Software, and to permit persons to whom the Software is | ||
# furnished to do so, subject to the following conditions: | ||
# | ||
# The above copyright notice and this permission notice shall be included | ||
# in all copies or substantial portions of the Software. | ||
# | ||
# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
# FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL THE | ||
# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
# SOFTWARE. | ||
set -e | ||
set -o pipefail | ||
|
||
output=$(realpath "$2") | ||
|
||
# TODO: REPLACE WITH ACTUAL METRIC CODE | ||
echo "IR 0.000 " >"${output}" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,68 @@ | ||
#!/usr/bin/env bash | ||
# shellcheck disable=SC2317 | ||
# TODO: REMOVE SHELLCHECK DISABLE RIGHT AFTER IMPLEMENTING ir.sh | ||
# The MIT License (MIT) | ||
# | ||
# Copyright (c) 2021-2024 Yegor Bugayenko | ||
# | ||
# Permission is hereby granted, free of charge, to any person obtaining a copy | ||
# of this software and associated documentation files (the "Software"), to deal | ||
# in the Software without restriction, including without limitation the rights | ||
# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
# copies of the Software, and to permit persons to whom the Software is | ||
# furnished to do so, subject to the following conditions: | ||
# | ||
# The above copyright notice and this permission notice shall be included | ||
# in all copies or substantial portions of the Software. | ||
# | ||
# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
# FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL THE | ||
# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
# SOFTWARE. | ||
set -e | ||
set -o pipefail | ||
|
||
# TODO: ENABLE THIS TESTS RIGHT AFTER IMPLEMENTING ir.sh VIA REMOVING `exit 0` | ||
exit 0 | ||
|
||
temp=$1 | ||
stdout=$2 | ||
|
||
{ | ||
tmp=$(mktemp -d /tmp/XXXX) | ||
cd "${tmp}" | ||
mkdir -p "${LOCAL}/${temp}" | ||
"${LOCAL}/metrics/ir.sh" ./ "${LOCAL}/${temp}/stdout" | ||
grep "Provided non-git repo" "${LOCAL}/${temp}/stdout" | ||
} > "${stdout}" 2>&1 | ||
echo "👍🏻 Didn't fail in non-git directory" | ||
|
||
{ | ||
tmp=$(mktemp -d /tmp/XXXX) | ||
cd "${tmp}" | ||
rm -rf ./* | ||
rm -rf .git | ||
git init --quiet . | ||
git config user.email '[email protected]' | ||
git config user.name 'Foo' | ||
"${LOCAL}/metrics/ir.sh" ./ "t0" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @zaqbez39me should fail here |
||
grep "No files in given repo" "t0" | ||
file1="one.java" | ||
file2="two.java" | ||
touch "${file1}" | ||
git add "${file1}" | ||
git config commit.gpgsign false | ||
git commit --quiet -m "first file" | ||
"${LOCAL}/metrics/ir.sh" ./ "t1" | ||
touch "${file2}" | ||
git add "${file2}" | ||
git commit --quiet -m "second file" | ||
"${LOCAL}/metrics/ir.sh" ./ "t2" | ||
grep "No files in given repo " "t0" # There are no files in repo | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
grep "ir 1 " "t1" # Single file in repo | ||
grep "ir 0.5 " "t2" # Two files in repo | ||
} > "${stdout}" 2>&1 | ||
echo "👍🏻 Correctly calculated the IR (Impact Ratio)" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zaqbez39me should fail here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yegor256 you want me to expect the
ir.sh
failing instead of printing anything here?