[draft] add limitations for restart and wait between restarts #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shmel1k
force-pushed
the
feature/add_possibility_to_limit_restarts_concurrency
branch
from
0682fa3 to
bbe39d5
Compare
elabpro
approved these changes
Dec 13, 2024
shmel1k
force-pushed
the
feature/add_possibility_to_limit_restarts_concurrency
branch
from
bbe39d5 to
483d904
Compare
shmel1k
force-pushed
the
feature/add_possibility_to_limit_restarts_concurrency
branch
from
17a9cbc to
6d8b006
Compare
sourcecd
approved these changes
Dec 14, 2024
Jorres
reviewed
Dec 15, 2024
pkg/rolling/restart_handler.go
Outdated
| } | ||
|
|
||
| func (rh *restartHandler) stop() { | ||
| rh.onceDone.Do(func() { |
There was a problem hiding this comment.
I am not convinced it is necessary. What are you protecting against? The channel should be closed only once in your code - if you somehow call stop twice, it is your problem and signifies some deeper issue with the code. I currently think we MUST NOT cover closing this channel with a sync.once.
shmel1k
force-pushed
the
feature/add_possibility_to_limit_restarts_concurrency
branch
from
5278602 to
fd38330
Compare
Jorres
requested changes
Dec 15, 2024
Jorres
approved these changes
Dec 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Options and description