KIKIMR-22202 Changes in PR template and docs for contributors with requirements to PR description #14031

galnat · 2025-01-30T14:38:12Z

Changelog entry

Added docs for contibutors with requirements to PR description.

Changed PR Template:

rename Additional Info to Description
add User Interface category

Changelog category

Documentation (changelog entry is not required)

Additional information

…quirements to PR description

github-actions · 2025-01-30T14:43:32Z

⚪ 2025-01-30 14:43:32 UTC Pre-commit check linux-x86_64-release-asan for 4324f33 has started.
⚪ 2025-01-30 14:49:33 UTC Artifacts will be uploaded here
⚪ 2025-01-30 14:51:57 UTC ya make is running...
🟢 2025-01-30 14:52:02 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
0	0	0	0	0	0

🟢 2025-01-30 14:52:08 UTC Build successful.

github-actions · 2025-01-30T14:49:10Z

✅ Documentation build

Revision built successfully
Revision preview link

github-actions · 2025-01-30T15:08:45Z

⚪ 2025-01-30 15:08:44 UTC Pre-commit check linux-x86_64-relwithdebinfo for 4324f33 has started.
⚪ 2025-01-30 15:08:58 UTC Artifacts will be uploaded here
⚪ 2025-01-30 15:11:30 UTC ya make is running...
🟢 2025-01-30 15:11:35 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
0	0	0	0	0	0

🟢 2025-01-30 15:11:47 UTC Build successful.

.github/PULL_REQUEST_TEMPLATE.md

ydb/docs/ru/core/contributor/suggest-change.md

Co-authored-by: Ivan Blinkov <[email protected]>

github-actions · 2025-02-02T09:30:54Z

✅ Documentation build

Revision built successfully
Revision preview link

github-actions · 2025-02-02T09:31:00Z

⚪ 2025-02-02 09:31:00 UTC Pre-commit check linux-x86_64-relwithdebinfo for 796117a has started.
⚪ 2025-02-02 09:31:13 UTC Artifacts will be uploaded here
⚪ 2025-02-02 09:33:38 UTC ya make is running...
🟢 2025-02-02 09:35:08 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
0	0	0	0	0	0

🟢 2025-02-02 09:35:14 UTC Build successful.

github-actions · 2025-02-02T09:31:10Z

⚪ 2025-02-02 09:31:09 UTC Pre-commit check linux-x86_64-release-asan for 796117a has started.
⚪ 2025-02-02 09:31:22 UTC Artifacts will be uploaded here
⚪ 2025-02-02 09:33:52 UTC ya make is running...
🟢 2025-02-02 09:35:31 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
0	0	0	0	0	0

🟢 2025-02-02 09:35:37 UTC Build successful.

github-actions · 2025-02-04T15:13:21Z

✅ Documentation build

Revision built successfully
Revision preview link

github-actions · 2025-02-04T15:16:57Z

✅ Documentation build

Revision built successfully
Revision preview link

github-actions · 2025-02-04T15:32:57Z

⚪ 2025-02-04 15:32:57 UTC Pre-commit check linux-x86_64-release-asan for a0686d9 has started.
⚪ 2025-02-04 15:33:16 UTC Artifacts will be uploaded here
⚪ 2025-02-04 15:35:47 UTC ya make is running...
🟢 2025-02-04 15:37:28 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
0	0	0	0	0	0

🟢 2025-02-04 15:37:37 UTC Build successful.

github-actions · 2025-02-04T15:40:37Z

❌ Documentation build

Revision build failed

Build logs

Errors (1)

❌ /ru/contributor/suggest-change.md: 300: MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]

github-actions · 2025-02-04T16:15:17Z

✅ Documentation build

Revision built successfully
Revision preview link

github-actions · 2025-02-04T16:26:13Z

⚪ 2025-02-04 17:10:41 UTC Pre-commit check linux-x86_64-release-asan for 2816237 has started.
⚪ 2025-02-04 17:11:38 UTC Artifacts will be uploaded here
⚪ 2025-02-04 17:14:52 UTC ya make is running...
🟢 2025-02-04 17:14:58 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
0	0	0	0	0	0

🟢 2025-02-04 17:15:06 UTC Build successful.

lgtm

ydb/docs/ru/core/contributor/suggest-change.md

github-actions · 2025-02-07T06:59:30Z

⚪ 2025-02-07 06:59:30 UTC Pre-commit check linux-x86_64-release-asan for be83c0a has started.
⚪ 2025-02-07 06:59:42 UTC Artifacts will be uploaded here
⚪ 2025-02-07 07:02:10 UTC ya make is running...
🟢 2025-02-07 07:03:38 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
0	0	0	0	0	0

🟢 2025-02-07 07:03:44 UTC Build successful.

github-actions · 2025-02-07T06:59:31Z

⚪ 2025-02-07 06:59:30 UTC Pre-commit check linux-x86_64-relwithdebinfo for be83c0a has started.
⚪ 2025-02-07 06:59:41 UTC Artifacts will be uploaded here
⚪ 2025-02-07 07:02:09 UTC ya make is running...
🟢 2025-02-07 07:03:34 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
0	0	0	0	0	0

🟢 2025-02-07 07:03:39 UTC Build successful.

github-actions · 2025-02-07T06:59:54Z

✅ Documentation build

Revision built successfully
Revision preview link

fomichev3000 · 2025-02-07T08:24:23Z

ydb/docs/ru/core/contributor/suggest-change.md

+
+1. **Changelog Entry.** В этот блок следует добавить описание изменения для конечных пользователей системы (см. [требования](#changelog_entry_req)). Содержимое этого блока будет опубликовано в [списке изменений](../changelog-server.md), если PR будет замержен.
+2. **Changelog Category.** В этом блоке нужно оставить одну категорию из списка, которой соответствует изменение (см. [как выбрать категорию](#choose_category)). Есть категории, для которых сообщения из Changelog Entry не будут опубликованы в списке изменений. Остальные категории определяют раздел списка изменений, в который попадёт сообщение.
+3. **Description.** В этот блок можно добавить ссылку на задачу и любую дополнительную информацию, которую вы считаете полезной для ревью. Содержимое этого блока не попадёт в список изменений.


Я бы сказал, что это описание для ревьювера, то есть для коллеги-разработчика. Предлагаю более явно выразить эту мысль. Например "Description for reviewer"

Поправила.

ydb/docs/ru/core/contributor/suggest-change.md

fomichev3000 · 2025-02-13T06:29:08Z

ydb/docs/ru/core/contributor/suggest-change.md

+
+При создании Pull Request'а описание будет заполнено текстом из шаблона, который нужно отредактировать:
+
+1. **Changelog Entry.** В этот блок следует добавить описание изменения для конечных пользователей системы (см. [требования](#changelog_entry_req)). Содержимое этого блока будет опубликовано в [списке изменений](../changelog-server.md), если PR будет замержен.


Я бы поменял местами Changelog Category и Changelog Entry. Сначала выбираешь категорию, потом уже пишешь текст. Если "Not for Changelog" то я бы написал, что Changelog Entry можно пропустить, так?

Поправила

Co-authored-by: Andrey Fomichev <[email protected]>

github-actions · 2025-02-13T20:11:50Z

⚪ 2025-02-13 20:11:50 UTC Pre-commit check linux-x86_64-release-asan for b739459 has started.
⚪ 2025-02-13 20:12:01 UTC Artifacts will be uploaded here
⚪ 2025-02-13 20:14:18 UTC ya make is running...
🟢 2025-02-13 20:14:23 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
0	0	0	0	0	0

🟢 2025-02-13 20:14:29 UTC Build successful.

github-actions · 2025-02-13T20:12:25Z

✅ Documentation build

Revision built successfully
Revision preview link

github-actions · 2025-02-13T20:12:45Z

⚪ 2025-02-13 20:12:45 UTC Pre-commit check linux-x86_64-relwithdebinfo for b739459 has started.
⚪ 2025-02-13 20:12:57 UTC Artifacts will be uploaded here
⚪ 2025-02-13 20:15:14 UTC ya make is running...
🟢 2025-02-13 20:15:19 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
0	0	0	0	0	0

🟢 2025-02-13 20:15:25 UTC Build successful.

github-actions · 2025-02-14T07:44:17Z

⚪ 2025-02-14 07:44:17 UTC Pre-commit check linux-x86_64-relwithdebinfo for e94aa62 has started.
⚪ 2025-02-14 07:44:41 UTC Artifacts will be uploaded here
⚪ 2025-02-14 07:47:44 UTC ya make is running...
🟢 2025-02-14 07:47:50 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
0	0	0	0	0	0

🟢 2025-02-14 07:47:56 UTC Build successful.

github-actions · 2025-02-14T07:46:49Z

✅ Documentation build

Revision built successfully
Revision preview link

github-actions · 2025-02-14T07:47:32Z

⚪ 2025-02-14 07:47:32 UTC Pre-commit check linux-x86_64-release-asan for e94aa62 has started.
⚪ 2025-02-14 07:47:45 UTC Artifacts will be uploaded here
⚪ 2025-02-14 07:50:13 UTC ya make is running...
🟢 2025-02-14 07:50:19 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
0	0	0	0	0	0

🟢 2025-02-14 07:50:25 UTC Build successful.

KIKIMR-22202 Changes in PR template and docs for contributors with re…

5bc5d8a

…quirements to PR description

galnat requested a review from a team as a code owner January 30, 2025 14:38

github-actions bot added the documentation Improvements or additions to documentation label Jan 30, 2025

blinkov previously requested changes Jan 31, 2025

View reviewed changes

Apply suggestions from code review

af6e11a

Co-authored-by: Ivan Blinkov <[email protected]>

galnat requested a review from antonkovalenko February 2, 2025 09:32

galnat added 3 commits February 4, 2025 17:44

update pr_labels.yaml

3d804a7

revert Improvement to PULL_REQUEST_TEMPLATE.md

4e016a1

update suggest-change.md

e4cfc39

update suggest-change.md

d67f735

fix doc build

b26ad6e

github-actions bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Feb 4, 2025

galnat requested review from nikitka and removed request for nikitka February 4, 2025 17:52

blinkov enabled auto-merge (squash) February 7, 2025 06:53

blinkov reviewed Feb 7, 2025

View reviewed changes

ydb/docs/ru/core/contributor/suggest-change.md Show resolved Hide resolved

ydb/docs/ru/core/contributor/suggest-change.md Outdated Show resolved Hide resolved

Apply suggestions from code review

4e4fdb3

antonkovalenko previously approved these changes Feb 7, 2025

View reviewed changes

fomichev3000 requested changes Feb 13, 2025

View reviewed changes

Update ydb/docs/ru/core/contributor/suggest-change.md

2c2bd8b

Co-authored-by: Andrey Fomichev <[email protected]>

galnat dismissed antonkovalenko’s stale review via 2c2bd8b February 13, 2025 20:08

update after review

fcaa877

fomichev3000 approved these changes Feb 14, 2025

View reviewed changes

blinkov merged commit 010e83f into ydb-platform:main Feb 14, 2025
13 checks passed

This was referenced Feb 15, 2025

YQ-4114 fixed pragmas for CTAS #14604

Merged

YQ remove anonymous namespace from CA #14636

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

KIKIMR-22202 Changes in PR template and docs for contributors with requirements to PR description #14031

KIKIMR-22202 Changes in PR template and docs for contributors with requirements to PR description #14031

galnat commented Jan 30, 2025 •

edited

Loading

github-actions bot commented Jan 30, 2025 •

edited

Loading

github-actions bot commented Jan 30, 2025

github-actions bot commented Jan 30, 2025 •

edited

Loading

github-actions bot commented Feb 2, 2025

github-actions bot commented Feb 2, 2025 •

edited

Loading

github-actions bot commented Feb 2, 2025 •

edited

Loading

github-actions bot commented Feb 4, 2025

github-actions bot commented Feb 4, 2025

github-actions bot commented Feb 4, 2025 •

edited

Loading

github-actions bot commented Feb 4, 2025

github-actions bot commented Feb 4, 2025

github-actions bot commented Feb 4, 2025 •

edited

Loading

github-actions bot commented Feb 7, 2025 •

edited

Loading

github-actions bot commented Feb 7, 2025 •

edited

Loading

github-actions bot commented Feb 7, 2025

fomichev3000 Feb 7, 2025

galnat Feb 14, 2025

fomichev3000 Feb 13, 2025

galnat Feb 14, 2025

github-actions bot commented Feb 13, 2025 •

edited

Loading

github-actions bot commented Feb 13, 2025

github-actions bot commented Feb 13, 2025 •

edited

Loading

github-actions bot commented Feb 14, 2025 •

edited

Loading

github-actions bot commented Feb 14, 2025

github-actions bot commented Feb 14, 2025 •

edited

Loading


		При создании Pull Request'а описание будет заполнено текстом из шаблона, который нужно отредактировать:

		1. Changelog Entry. В этот блок следует добавить описание изменения для конечных пользователей системы (см. [требования](#changelog_entry_req)). Содержимое этого блока будет опубликовано в [списке изменений](../changelog-server.md), если PR будет замержен.

KIKIMR-22202 Changes in PR template and docs for contributors with requirements to PR description #14031

KIKIMR-22202 Changes in PR template and docs for contributors with requirements to PR description #14031

Conversation

galnat commented Jan 30, 2025 • edited Loading

Changelog entry

Changelog category

Additional information

github-actions bot commented Jan 30, 2025 • edited Loading

github-actions bot commented Jan 30, 2025

✅ Documentation build

github-actions bot commented Jan 30, 2025 • edited Loading

github-actions bot commented Feb 2, 2025

✅ Documentation build

github-actions bot commented Feb 2, 2025 • edited Loading

github-actions bot commented Feb 2, 2025 • edited Loading

github-actions bot commented Feb 4, 2025

✅ Documentation build

github-actions bot commented Feb 4, 2025

✅ Documentation build

github-actions bot commented Feb 4, 2025 • edited Loading

github-actions bot commented Feb 4, 2025

❌ Documentation build

Build logs

Errors (1)

github-actions bot commented Feb 4, 2025

✅ Documentation build

github-actions bot commented Feb 4, 2025 • edited Loading

github-actions bot commented Feb 7, 2025 • edited Loading

github-actions bot commented Feb 7, 2025 • edited Loading

github-actions bot commented Feb 7, 2025

✅ Documentation build

fomichev3000 Feb 7, 2025

Choose a reason for hiding this comment

galnat Feb 14, 2025

Choose a reason for hiding this comment

fomichev3000 Feb 13, 2025

Choose a reason for hiding this comment

galnat Feb 14, 2025

Choose a reason for hiding this comment

github-actions bot commented Feb 13, 2025 • edited Loading

github-actions bot commented Feb 13, 2025

✅ Documentation build

github-actions bot commented Feb 13, 2025 • edited Loading

github-actions bot commented Feb 14, 2025 • edited Loading

github-actions bot commented Feb 14, 2025

✅ Documentation build

github-actions bot commented Feb 14, 2025 • edited Loading

galnat commented Jan 30, 2025 •

edited

Loading

github-actions bot commented Jan 30, 2025 •

edited

Loading

github-actions bot commented Jan 30, 2025 •

edited

Loading

github-actions bot commented Feb 2, 2025 •

edited

Loading

github-actions bot commented Feb 2, 2025 •

edited

Loading

github-actions bot commented Feb 4, 2025 •

edited

Loading

github-actions bot commented Feb 4, 2025 •

edited

Loading

github-actions bot commented Feb 7, 2025 •

edited

Loading

github-actions bot commented Feb 7, 2025 •

edited

Loading

github-actions bot commented Feb 13, 2025 •

edited

Loading

github-actions bot commented Feb 13, 2025 •

edited

Loading

github-actions bot commented Feb 14, 2025 •

edited

Loading

github-actions bot commented Feb 14, 2025 •

edited

Loading