Support QueryMeta and diagnostics #11371
Conversation
|
⚪ |
|
⚪ |
|
⚪ |
|
⚪ |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
shnikd
force-pushed
the
collect-full-diagnostics
branch
from
4f19586 to
2ce9291
Compare
|
⚪ |
|
⚪ |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| @@ -43,6 +44,8 @@ void TCommandSql::Config(TConfig& config) { | |||
| config.Opts->AddLongOption("syntax", "Query syntax [yql, pg]") | |||
| .RequiredArgument("[String]").DefaultValue("yql").StoreResult(&Syntax) | |||
| .Hidden(); | |||
| config.Opts->AddLongOption("collect-diagnostics", "Collects diagnostics and saves it to file") | |||
There was a problem hiding this comment.
А новая опция прошла саппорт?
| @@ -235,6 +245,11 @@ int TCommandSql::PrintResponse(NQuery::TExecuteQueryIterator& result) { | |||
| queryPlanPrinter.Print(*plan); | |||
| } | |||
|
|
|||
| if (CollectFullDiagnostics) { | |||
| TFileOutput file(TStringBuilder() << "diagnostics_" << TGUID::Create().AsGuidString() << ".txt"); | |||
There was a problem hiding this comment.
А почему диагностику грузим в рандомный файл? Не лучше дать пользователю дать возможность указать путь до файла?
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ |
|
⚪ |
Co-authored-by: Bulat <[email protected]>
… collect-full-diagnostics
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| @@ -43,4 +43,7 @@ message QueryStats { | |||
| string query_ast = 5; | |||
| uint64 total_duration_us = 6; | |||
| uint64 total_cpu_time_us = 7; | |||
| // will be filled only in MODE_EXPLAIN or in MODE_EXEC with QueryStatsCollection.Mode >= STATS_COLLECTION_FULL, | |||
| // collects additional meta about query compilation, including table metadata | |||
| string query_meta = 8; | |||
There was a problem hiding this comment.
shipping this on behalf of the internal discussion
No description provided.