NBS-4684: [Disk Manager] use proxy overlay disks in relocation if possible #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
тут надо large тесты прогнать |
BarkovBG
changed the title
все ок |
jkuradobery
reviewed
Feb 7, 2024
cloud/disk_manager/internal/pkg/dataplane/create_snapshot_from_disk_task.go
Outdated
Show resolved
Hide resolved
cloud/disk_manager/internal/pkg/dataplane/replicate_disk_task.go
Outdated
Show resolved
Hide resolved
jkuradobery
previously approved these changes
Feb 8, 2024
SvartMetal
reviewed
Feb 9, 2024
cloud/disk_manager/internal/pkg/dataplane/protos/replicate_disk_task.proto
Outdated
Show resolved
Hide resolved
SvartMetal
reviewed
Feb 9, 2024
cloud/disk_manager/internal/pkg/dataplane/replicate_disk_task.go
Outdated
Show resolved
Hide resolved
SvartMetal
reviewed
Feb 9, 2024
cloud/disk_manager/internal/pkg/dataplane/replicate_disk_task.go
Outdated
Show resolved
Hide resolved
SvartMetal
reviewed
Feb 9, 2024
SvartMetal
reviewed
Feb 9, 2024
cloud/disk_manager/internal/pkg/dataplane/replicate_disk_task.go
Outdated
Show resolved
Hide resolved
BarkovBG
added
the
disk_manager
jkuradobery
approved these changes
Feb 12, 2024
SvartMetal
approved these changes
Feb 12, 2024
gy2411
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
need to use proxy overlay disk in relocation
now data path looks like
snapshot -> nbs control -> host with volume tablet -> nbs control -> snapshot
after this optimization it will be
snapshot -> nbs control -> snapshot