Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checksum write buffer before and after write #2985

Merged
merged 7 commits into from
Feb 11, 2025
Merged

Checksum write buffer before and after write #2985

merged 7 commits into from
Feb 11, 2025

Conversation

drbasic
Copy link
Collaborator

@drbasic drbasic commented Feb 6, 2025 •
edited
Loading

#2988

  1. Считаем чексумму буфера который будем писать
  2. После окончания записи считаем чексумму еще раз
  3. Если чексуммы разошлись, то копируем данные во временный буфер. Этот буфер будет содержать какие-то модифицированные данные относительно начала, но видимо так хотел клиент.
  4. Повторяем запись, теперь во все реплики должны попасть одинаковые данные.

@SvartMetal SvartMetal self-requested a review February 6, 2025 13:05
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 6, 2025

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit c9c44a0.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
6287 6281 0 1 3 2

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 1079c06.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
6257 6249 0 5 0 3

@drbasic drbasic force-pushed the users/drbasic/checksum-write-buffer branch from a53ab35 to dce6134 Compare February 7, 2025 09:05
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit dce6134.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
6315 6309 0 0 4 2

@drbasic drbasic added the blockstore Add this label to run only cloud/blockstore build and tests on PR label Feb 7, 2025
@drbasic drbasic mentioned this pull request Feb 7, 2025
Open
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025 •
edited
Loading

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 5810363.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3617 3616 0 1 0 0

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 5810363.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3617 3617 0 0 0 0

@drbasic drbasic requested a review from agalibin February 10, 2025 12:38
@sharpeye sharpeye self-requested a review February 10, 2025 22:33
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit a174438.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3617 3617 0 0 0 0

@drbasic drbasic merged commit 39c744c into main Feb 11, 2025
11 of 19 checks passed
@drbasic drbasic deleted the users/drbasic/checksum-write-buffer branch February 11, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharpeye sharpeye sharpeye approved these changes

@agalibin agalibin agalibin approved these changes

@komarevtsev-d komarevtsev-d komarevtsev-d approved these changes

@SvartMetal SvartMetal Awaiting requested review from SvartMetal

Assignees
No one assigned
Labels
blockstore Add this label to run only cloud/blockstore build and tests on PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@drbasic @SvartMetal @sharpeye @agalibin @komarevtsev-d