issue-1932: use ceil instead of floor for calculating shards count #2982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debnatkh
added
the
filestore
debnatkh
force-pushed
the
users/debnatkh/floor-ceil
branch
2 times, most recently
from
2fb5109 to
8a4ad6e
Compare
debnatkh
force-pushed
the
users/debnatkh/floor-ceil
branch
from
8a4ad6e to
5dd0889
Compare
SvartMetal
approved these changes
Feb 6, 2025
yegorskii
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #1932
Currently a shard of 5TiB is created per each 4TiB in the filesystem (rounding the number of shards down). So if the filesystem is the size of 7TiB, only one shard of size 5TiB will be created. In this PR rounding down is replaced with rounding up.