issue-2947: add connections warmup on nbs bootstrap #2977
+82
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Thank you for contributing! |
komarevtsev-d
added
blockstore
github-actions
bot
removed
the
ok-to-test
vladstepanyuk
force-pushed
the
issue-2947
branch
from
cc5bebc to
43cba89
Compare
komarevtsev-d
added
the
ok-to-test
github-actions
bot
removed
the
ok-to-test
vladstepanyuk
force-pushed
the
issue-2947
branch
from
3cb24a2 to
41f7d29
Compare
komarevtsev-d
added
the
ok-to-test
github-actions
bot
removed
the
ok-to-test
SvartMetal
reviewed
Feb 5, 2025
| } | ||
|
|
||
| auto tabletBootInfoBackupFilePath = | ||
| TFsPath(Configs->StorageConfig->GetTabletBootInfoBackupFilePath()); |
There was a problem hiding this comment.
тут мы лезем в кишки hive proxy
вместо этого можно полистить все backup'ы при помощи https://github.com/ydb-platform/nbs/blob/main/cloud/storage/core/libs/hive_proxy/hive_proxy_events_private.h#L104
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2947
Провели пару замеров на проде и прогрев соеденений дал улучшение в пару секунд для максимального летенси на пользовательской стороне во время рестарта.
Уже есть тест cloud/blockstore/tests/loadtest/local-emergency/test.py который делает BackupTabletBootInfos и затем рестартит nbs, поэтому наш случай уже покрыт тестами.