issue-2277: move copying of the request buffer to TIORequestParserActor #2946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharpeye
added
blockstore
sharpeye
force-pushed
the
users/sharpeye/issue-2277-allocate-buffer
branch
from
6189007 to
86a0da1
Compare
sharpeye
force-pushed
the
users/sharpeye/issue-2277-allocate-buffer
branch
from
e8c1e88 to
e20922c
Compare
drbasic
approved these changes
Jan 31, 2025
tpashkin
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2277
Aio has a buffer alignment requirement. To meet this requirement, TStorageAdapter allocates an additional buffer and copies the data from the request into it. The copying takes place in a single TDiskAgentActor thread, which creates scalability issues.
In order to improve scalability, the allocation and copying of data has been moved to the IORequestParserActor.