issue-2722: add ability to read from certain replica of mirrored disk #2918
+254
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilyTiger
force-pushed
the
users/wilytiger/issue-2722-3
branch
from
eb6020e to
b0eafc5
Compare
sharpeye
reviewed
Feb 3, 2025
| Opts.AddLongOption( | ||
| "replica-index", | ||
| "from which replica(numerate from 1) read data, only for " | ||
| "ssd-io disks") |
There was a problem hiding this comment.
В blockstore-client есть mirrorX/ssd_mirrorX, про ssd-io он не знает
Comment on lines
+432
to
+455
| if (replicaIndex) { | ||
| if (replicaIndex > State.GetReplicaInfos().size()) { | ||
| auto response = | ||
| std::make_unique<typename TMethod::TResponse>(MakeError( | ||
| E_ARGUMENT, | ||
| TStringBuilder() | ||
| << "Request " << TMethod::Name | ||
| << " has incorrect ReplicaIndex " << replicaIndex | ||
| << " disk has " << State.GetReplicaInfos().size() | ||
| << " replicas")); | ||
| NCloud::Reply(ctx, *ev, std::move(response)); | ||
| return; | ||
| } | ||
|
|
||
| if (!replicaActorIds.insert(replicaActorId).second) { | ||
| break; | ||
| const auto& replicaInfo = State.GetReplicaInfos()[replicaIndex - 1]; | ||
| if (!replicaInfo.Config->DevicesReadyForReading(blockRange)) { | ||
| auto response = | ||
| std::make_unique<typename TMethod::TResponse>(MakeError( | ||
| E_REJECTED, | ||
| TStringBuilder() << "Cannot process " << TMethod::Name | ||
| << " cause replica " << replicaIndex | ||
| << " has not ready devices")); | ||
| NCloud::Reply(ctx, *ev, std::move(response)); | ||
| return; |
There was a problem hiding this comment.
Лучше вынести выбор реплик в отдельную функцию:
auto TMirrorPartitionActor::SelectReplicasToReadFrom(
ui32 replicaIndex,
TBlockRange64 blockRange) -> TResultOrError<TVector<TActorId>>
{...}const auto replicaIndex = record.GetHeaders().GetReplicaIndex();
auto [replicaActorIds, error] =
SelectReplicasToReadFrom(replicaIndex, blockRange);
if (HasError(error)) {
NCloud::Reply(ctx, *ev, std::make_unique<TResponse>(error));
return;
}| if (replicaIndex) { | ||
| if (replicaIndex > State.GetReplicaInfos().size()) { | ||
| auto response = | ||
| std::make_unique<typename TMethod::TResponse>(MakeError( |
There was a problem hiding this comment.
Удобно сделать using в начале фyнкции:
using TResponse = TMethod::TResponse;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to provide better diagnostics for checksum mismatches in replicas, I want to add the ability for blockstore-client to read certain replica and compare it further in scripts